Define move assignment in SoATuple.h

[wddgit]

PR description:

Define move assignment in SoATuple.h. The immediate motivation for this is to silence a clang compiler warning that was recently enabled. Also bring code into conformance with CMS code guidelines. Plus it might be useful someday.

PR validation:

Added to SoATuple unit test to cover this function. Note nothing in CMSSW could be using this so it should not affect any existing code.

if this PR is a backport please specify the original PR:

Not a backport

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #26592
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2337/console Started: 2019/09/03 21:44

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27921/11749

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Utilities

@smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Tested at: 73f3529

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28843d/2337/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2363/console Started: 2019/09/04 18:33

[cmsbuild]

+1
Tested at: 73f3529
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce53fe/2363/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce53fe/2363/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2955700
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2955358
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[fabiocos]

+1