Explicitly removed methods implicitly ignored by compiler in FWCore/Framework

[Dr15Jones]

PR description:

Although we had asked the compiler explicitly to create default versions
of functions, it was implicitly deleting them. Now we explicitly
request them to be deleted to match what the compiler was doing.

This fixes new clang warnings.

PR validation:

Compiled FWCore/Framework under CMSSW_11_0_CLANG_X_2019-09-03-2300. The only remaining clang warnings come from CppUnit external package.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27927/11762

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/interface/SubProcess.h modified in PR(s): Implement core support for concurrent IOVs #26592

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[Dr15Jones]

@wddgit does this conflict with your changes?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2359/console Started: 2019/09/04 16:40

[wddgit]

@Dr15Jones No conflict with either PR. Only one file (SubProcess.h) is also modified by one of my PRs, PR #26592, but the changed lines in the PRs are separated by multiple lines.

The SoATuple PR is no longer necessary after this one, but still seems like an improvement so I will continue with it.

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) #26592
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2362/console Started: 2019/09/04 18:31

[cmsbuild]

+1
Tested at: 33082bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bba28/2362/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bba28/2362/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2955700
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2955358
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

@smuzaffar why did the bot add requires-external tag to this pull request?

[smuzaffar]

yes its a bug, as #26592 was tested using this PR that is why bot assumes that both PR require each other.

[fabiocos]

+1