Fixing VID return value for HEEP Trk Iso: 10_6_X

[Sam-Harper]

PR description:

Fixes the HEEP track isolation value returned by VID. No changes in any workflow or result is expected, its purely for analyse level

if this PR is a backport please specify the original PR:

Backport of : #27944 (see for more details)

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for CMSSW_10_6_X.

It involves the following packages:

RecoEgamma/ElectronIdentification

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fixing VID return value for HEEP Trk Iso: 11_0_X #27944

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2400/console Started: 2019/09/06 14:14

[cmsbuild]

+1
Tested at: ca7c5c8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c79c2b/2400/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c79c2b/2400/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211049
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210713
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

Backport of #27944

[slava77]

+1

for #27945 ca7c5c8

• code changes are in line with the PR description
  • the backport of Fixing VID return value for HEEP Trk Iso: 11_0_X #27944 is correct
  • the changes are indeed for analysis only; no changes are expected in results of the code used in production
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

@fabiocos
please comment on prospects of merging this PR.
It looks like it did not make it to 10_6_4, even though the more intrusive DeepTau update made it.

[fabiocos]

@slava77 this fix has just entered into pre9, so normally I would wait for a validation there. Anyway I see this is not going to impact production workflows, so it may enter at next opportunity (even a simple patch if deemed urgent)

[fabiocos]

+1