Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix headers for check-headers errors reported in PR 27841 #27951

Merged
merged 1 commit into from
Sep 7, 2019

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Sep 7, 2019

PR description:

Fix for the issues with scram b check-headers reported in #27841

PR validation:

scram b check-headers errors are solved, the code compiles correctly

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27951/11807

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

GeneratorInterface/LHEInterface
PhysicsTools/Utilities

@efeyazgan, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy, @santocch can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 7, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2424/console Started: 2019/09/07 16:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f971c/2424/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955796
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2955454
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 7, 2019

@santcch @qliphy @agrohsje please check, it is just a technical fix

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 7, 2019

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 7, 2019

merge

@cmsbuild cmsbuild merged commit fbfeafb into cms-sw:master Sep 7, 2019
@qliphy
Copy link
Contributor

qliphy commented Sep 7, 2019

+1

@santocch
Copy link

santocch commented Sep 9, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@fabiocos fabiocos deleted the fc-fix-headers2-20190907 branch September 25, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants