-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly declare copy assignment for bqueue #27992
Conversation
The clang compiler was warning about classes which had bqueue objects as members were unable to implement copy assignment operators because bqueue had not explicitly declared one.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27992/11888
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: TrackingTools/PatternTools @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The clang compiler was warning about classes which had bqueue objects as members were unable to implement copy assignment operators because bqueue had not explicitly declared one.
PR validation:
Compiling under clang no longer gives a warning.
The extension of the unit test to test copy assignment passes.