-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snapshot in data offline GTs and Egamma regression, and update Strip 2018 MC conditions #28053
Conversation
A new Pull Request was created by @tocheng (Tongguang) for CMSSW_10_6_X. It involves the following packages: Configuration/AlCa @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@tocheng @tlampen @christopheralanwest @ggovi @fabiocos I see that you don't build the release yet, should we integrate this PR to patch1 also? It's an update on autocond for the last GT for UL-2018. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@srimano Design GTs were not updated. I added new commit. If test passes, I will sign off this PR. |
We are really waiting for the new release for final validation. If it's not ready, I think I would like to propose to make the release now, and this goes to the next one. |
Comparison is ready Comparison Summary:
|
@cmsbuild please test workflow 7.2,7.4 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR contains a fix of snapshot for data offline GTs addressed at [1].
EGamma PF cluster correction tags[2] for 2018 ultra-legacy reprocessing are updated due a bug described at [3]. The corrections affect 2018 MC and the 2018 IOVs of the offline GTs. Since the same corrections used for 2018 are intended to be used for Run 3 as well, the Run 3 MC GTs are updated as well.
Strip MC conditions for 2018 are updated to have a better data V.S. MC comparison[4]
[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4223.html
[2] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4222/1/1.html
[3] https://indico.cern.ch/event/842863/contributions/3562026/attachments/1906927/3149650/updates_2018ULPFCorrections.pdf
[4]https://indico.cern.ch/event/854616/#7-strip-mc-conditions-for-ul-2
GT diffs:
Data offline GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_v24/106X_dataRun2_v23
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_v22/106X_dataRun2_relval_v21
Data prompt-like GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_v13/106X_dataRun2_PromptLike_v12
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HEfail_v12/106X_dataRun2_PromptLike_HEfail_v11
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_PromptLike_HI_v13/106X_dataRun2_PromptLike_HI_v12
2018 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_design_v6/106X_upgrade2018_design_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_v11/106X_upgrade2018_realistic_v8
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_HEfail_v11/106X_upgrade2018_realistic_HEfail_v8
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018_realistic_HI_v6/106X_upgrade2018_realistic_HI_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018cosmics_realistic_deco_v7/106X_upgrade2018cosmics_realistic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2018cosmics_realistic_peak_v8/106X_upgrade2018cosmics_realistic_peak_v4
Run 3 MC GTs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021_design_v5/106X_upgrade2021_design_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021_realistic_v11/106X_upgrade2021_realistic_v10
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_upgrade2021cosmics_realistic_deco_v4/106X_upgrade2021cosmics_realistic_deco_v3
PR validation:
See the description above for the physics validation of the tags.
In addition, a technical test was performed: runTheMatrix.py -l limited -i all --ibeos