Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Puppiproducer to include fillDescriptions (backport 106X) #28137

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

alefisico
Copy link
Contributor

PR description:

This is a backport from #28020
To test PUPPI at HLT for Run3/PhaseII, PuppiProducer has to be updated with the fillDescription function to be recognized in condfb. This PR introduces this function in that producer. This change should be completely transparent to the PUPPI algorithm itself, or any other part of CMSSW.

PR validation:

Run runTheMatrix.py -l limited -i all --ibeos, and all the test passed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_10_6_X.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @riga, @jdolen, @gkasieczka, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Oct 9, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2849/console Started: 2019/10/09 15:04

@perrotta
Copy link
Contributor

perrotta commented Oct 9, 2019

backport of #28020

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab35d1/2849/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212305
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211970
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Oct 9, 2019

+1

  • Functionally identical to the backported PR (just some code format update missing)
  • Configuration description and validation added
  • Jenkins tests pass and show no differences, as it should

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

+1

@cmsbuild cmsbuild merged commit e80029c into cms-sw:CMSSW_10_6_X Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants