-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10_6_X] Fix a discrepancy in Puppi weights when running on MiniAOD w/ useExistingWeights=False #28169
Conversation
A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X. It involves the following packages: CommonTools/PileupAlgos @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #28033 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@hqucms |
+1
@fabiocos my comments in the ORP were based on the #28033 ; after some more careful look in this PR, I see that it should be OK for integration @hqucms please edit the PR description to clarify that the standard miniAOD or nanoAOD production are not affected |
@slava77 thanks for the clarification, as I have noted in the spreadsheet this is not a real complete backport |
@slava77 I have updated the PR description accordingly. Let me know if you still need the plots mentioned in #28169 (comment). |
I think that the plots would still be helpful mostly to clarify the level of previous disagreement and the newly updated agreement between running from AOD and that from miniAOD. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
1 similar comment
+1 |
@smuzaffar the bot looks stuck on this PR... |
it was due to github issue https://www.githubstatus.com/incidents/42hkbtl63nmn |
@smuzaffar ok, thanks for the clarification |
PR description:
Backport of #28033.
This is a minimal fix without the code simplification in #28033.
The discrepancy happens only when remaking puppi from miniAOD in analysis setup or other non-standard workflows, with
useExistingWeights=False
, and is fixed in this PR.Standard miniAOD or nanoAOD productions are not affected.