Clean redundant member functions from ElectronSeed

[guitargeek]

PR description:

When I checked out the pixel matching code for my previous PR I noticed there were some redundant member functions in the ElectronSeed class that were flagged for a cleanup. These member functions were originally kept for backwards compatibility with the old ElectronSeed class so the new ElectronSeed could be quickly integrated without adapting function calls in all of CMSSW. in Probably it's now a good time for removing them.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR:

No backport intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28198/12303

• This PR adds an extra 108KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoEgamma/EgammaElectronAlgos/src/ElectronSeedGenerator.cc modified in PR(s): Fix problem with fromTrackerSeeds parameter in ElectronSeedProducer and improve LayerMeasurements class #28039

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DataFormats/EgammaReco
HLTrigger/Egamma
RecoEgamma/EgammaElectronAlgos
RecoEgamma/Examples
Validation/RecoEgamma

@perrotta, @cmsbuild, @andrius-k, @kmaeshima, @fwyzard, @schneiml, @Martin-Grunewald, @jfernan2, @fioriNTU, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @rovere, @lgray, @Martin-Grunewald, @sobhatta, @afiqaize, @varuns23 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3008/console Started: 2019/10/17 14:56

[cmsbuild]

+1
Tested at: 9b86308
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-380c3d/3008/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-380c3d/3008/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2961064
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2960721
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[slava77]

+1

for #28198 81c2059

• technical
• jenkins tests pass

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1