Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consumes to DTConfigDBProducer #28216

Merged
merged 3 commits into from Oct 29, 2019

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • Required change to DTKeyedConfigCache to not get cond::persistency::KeyList itself but instead have the object passed to it.
  • Changed DTConfigDBProducer and DTKeyedConfigDump to use ESGetTokens.

PR validation:

runTheMatrix.py tests using the ESProducer still run.

This allows consumes calls to be made in the ESProducer and
EDAnalyzer which use the class.
@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Oct 18, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

Additional issues found with cond::persistency::KeyList are described here: #28203 .

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28216/12335

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondTools/DT
L1TriggerConfig/DTTPGConfigProducers

@ggovi, @rekovic, @benkrikler, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3033/console Started: 2019/10/18 22:57

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25fc0b/3033/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961064
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960722
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 21, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) #28223,#28215,#28217,#28218
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3056/console Started: 2019/10/21 16:18

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

The only change with respect to the previous test run is I moved a comment to a different line.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28216/12435

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3154/console Started: 2019/10/25 14:34

@cmsbuild
Copy link
Contributor

Pull request #28216 was updated. @ggovi, @rekovic, @benkrikler, @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25fc0b/3154/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961036
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2960694
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Oct 28, 2019

+1

@Dr15Jones
Copy link
Contributor Author

please review @rekovic, @benkrikler This pull request is needed for more changes that are waiting.

@fabiocos
Copy link
Contributor

@rekovic @benkrikler this has been pending since quite sometime, please have a look, I will integrate it after pre11 is built

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7598fa8 into cms-sw:master Oct 29, 2019
@Dr15Jones Dr15Jones deleted the consumesDTConfigDBProducer branch October 30, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants