-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added consumes to DTConfigDBProducer #28216
Conversation
This allows consumes calls to be made in the ESProducer and EDAnalyzer which use the class.
The code-checks are being triggered in jenkins. |
Additional issues found with |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28216/12335
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondTools/DT @ggovi, @rekovic, @benkrikler, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
The only change with respect to the previous test run is I moved a comment to a different line. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28216/12435
|
The tests are being triggered in jenkins. |
Pull request #28216 was updated. @ggovi, @rekovic, @benkrikler, @cmsbuild can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
please review @rekovic, @benkrikler This pull request is needed for more changes that are waiting. |
@rekovic @benkrikler this has been pending since quite sometime, please have a look, I will integrate it after pre11 is built |
+1 |
merge |
PR description:
cond::persistency::KeyList
itself but instead have the object passed to it.PR validation:
runTheMatrix.py tests using the ESProducer still run.