Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getEngine() function from random service #2827

Merged

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Mar 12, 2014

In the random number generator service, remove the
getEngine function which takes no arguments. This function
is replaced by new getEngine functions that take either
a StreamID or a LuminosityBlockIndex as an argument. This
comes after a long migration of all clients to the new
interface. The new interace is designed to work with
the multithreaded Framework.

(Note that this also fixes a compilation error that resulted
after a similar pull request was automatically merged from
7_1_X)

In the random number generator service, remove the
getEngine function which takes no arguments. This function
is replaced by new getEngine functions that take either
a StreamID or a LuminosityBlockIndex as an argument. This
comes after a long migration of all clients to the new
interface. The new interace is designed to work with
the multithreaded Framework.

(Note that this also fixes a compilation error that resulted
after a similar pull request was automatically merged from
7_1_X)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_THREADED_X.

Remove getEngine() function from random service

It involves the following packages:

FWCore/Utilities
IOMC/RandomEngine

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@wddgit
Copy link
Contributor Author

wddgit commented Mar 12, 2014

I did not do a 'checkdeps -a' test with this to try to get it out faster. I'm assuming the jenkins test will take care of that. Without this the THREADED branch already fails compilation because of a problem in a recent automatic merge from 7_1_X.

@Dr15Jones
Copy link
Contributor

+1
@ktf this needs to be picked up to fix the 0200 build for _THREADED

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_THREADED_X IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Mar 12, 2014
Multithreading fixes -- Remove getEngine() function from random service
@ktf ktf merged commit 234aca6 into cms-sw:CMSSW_7_1_THREADED_X Mar 12, 2014
@wddgit wddgit deleted the removeRandomDeprecatedInterface3 branch April 25, 2014 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants