(DAQ) Revert to untracked parameters and new configuration

[smorovic]

PR description:

Reverting to untracked parameters in EvFDaqDirector as discussed in #28151
Including also these changes:

• new parameter is added to control if fileBrokeHost parameter can be changed within the process by looking at hltd configuration (which is current behavior).
• default value is removed from fileBrokerHost, so it must always be present for the configuration to run successfully.
• other parameters in the service have also been regrouped, and one was renamed.

PR validation:

Tested in DAQ "VM" test cluster with several relevant combinations of parameters. RunBUFU.sh in EventFilter/Utilities/test also runs fine.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12658

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12658/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12658/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12659

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @smorovic (Srecko Morovic) for master.

It involves the following packages:

EventFilter/Utilities

@perrotta, @mommsen, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

@smorovic
On this issue:

default value is removed from fileBrokerHost, so it must always be present for the configuration to run successfully.

please do NOT do this: parameters without a default will not be written to the fillDescriptions generated cfi file (as the code does not know which value to put).
In turn, ConfDB parsing the cfi file will never know about this parameter.
So you will never be able to set it to any value in ConfDB!
Please revert and give a value, even is it is a value of "InValid" or so, and you check the string being "InValid" and issue an error message then!

[cmsbuild]

The code-checks are being triggered in jenkins.

[smorovic]

Well, maybe "addUntracked" (or even "add") function without default should then be removed, unless there is use case I don't see.

It has now been changed to InValid as default.

[Martin-Grunewald]

Thanks.
People not using ConfDB GUI are able to use the feature, but ConfDB uses cfi files to discover the parameters, so for that use case all parameters must appear in the fillDescriptions generated cfi file.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12660

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12660/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12660/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28359/12661

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #28359 was updated. @perrotta, @mommsen, @cmsbuild, @emeschi, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3385/console Started: 2019/11/07 22:45

[cmsbuild]

+1
Tested at: 1749535
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e2038/3385/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e2038/3385/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2936360
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2936008
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #28359 1749535

• reco code is not affected

[fabiocos]

@mommsen comments?

[mommsen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1