removing use of statics in reco

[davidlange6]

fix a few modules using statics in the reco sequence
CaloTowersCreator
HcalHitReconstructor
JetPlusTrackProducer
RPCUnpackingModule

[cmsbuild]

A new Pull Request was created by @davidlange6 for CMSSW_7_1_X.

removing use of statics in reco

It involves the following packages:

EventFilter/RPCRawToDigi
RecoJets/JetPlusTracks
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecAlgos

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

This would also have worked

static const std::vector<double> retval = {0.,10.,20.,30.,40.,50.,100.,1000.};

[davidlange6]

Since its unused code I just removed it...

On Mar 13, 2014, at 2:42 PM, "Chris Jones" <notifications@github.commailto:notifications@github.com> wrote:

In RecoLocalCalo/CaloTowersCreator/src/CaloTowersCreator.cc:

#include "Geometry/CaloTopology/interface/HcalTopology.h"
// severity level for ECAL
#include "RecoLocalCalo/EcalRecAlgos/interface/EcalSeverityLevelAlgoRcd.h"
#include "CommonTools/Utils/interface/StringToEnumValue.h"

-const std::vector&
-CaloTowersCreator::getGridValues()
-{

• static std::vector retval;

This would also have worked

static const std::vector retval = {0.,10.,20.,30.,40.,50.,100.,1000.};

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2845/files#r10564194.

[Dr15Jones]

Always the prefered solution :)

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2845/527/summary.html

[anton-a]

Running some extra tests...

[anton-a]

+1
No regressions.
Note that some of the changes affect parts of code not run in normal reco. Some of the code may or may not be rally needed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?