Add a flag to disable matching in SiStripRecHitConverter

[makortel]

PR description:

This PR proposes to add a configuration parameter doMatching (defaults to True) to SiStripRecHitConverter to allow disabling the strip matching. The motivation is to test mkFit within a customized HLT menu: mkFit needs all rphi+stereo hits as an input, but not the matched ones, and matching is rather expensive (as a reminder the current tracking creates the hit objects on the fly). In order to support the new parameter in existing HI HLT menus, I implemented fillDescriptions().

While at it, I decided to migrate the SiStripRecHitConverter to use ESGetToken. As a preparatory steps I did two modernizations: moved TYPELOOKUP_DATA_REG to its own file as suggested in the EventSetup instructions, and removed the use of cached IDs as they're not really useful for just getting the EventSetup products.

PR validation:

Limited matrix runs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28471/12912

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoLocalTracker/SiStripRecHitConverter

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @alesaggio, @felicepantaleo, @gpetruc, @ebrondol, @threus, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3630/console Started: 2019/11/26 01:08

[cmsbuild]

+1
Tested at: 030d181
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-971463/3630/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-971463/3630/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2787584
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787241
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #28471 030d181

• code changes are in line with the PR description; mostly technical
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1