-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to disable matching in SiStripRecHitConverter #28471
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28471/12912
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoLocalTracker/SiStripRecHitConverter @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 for #28471 030d181
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR proposes to add a configuration parameter
doMatching
(defaults toTrue
) toSiStripRecHitConverter
to allow disabling the strip matching. The motivation is to test mkFit within a customized HLT menu: mkFit needs all rphi+stereo hits as an input, but not the matched ones, and matching is rather expensive (as a reminder the current tracking creates the hit objects on the fly). In order to support the new parameter in existing HI HLT menus, I implementedfillDescriptions()
.While at it, I decided to migrate the
SiStripRecHitConverter
to use ESGetToken. As a preparatory steps I did two modernizations: movedTYPELOOKUP_DATA_REG
to its own file as suggested in the EventSetup instructions, and removed the use of cached IDs as they're not really useful for just getting the EventSetup products.PR validation:
Limited matrix runs.