Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumes for valid cscrechits #2850

Merged
merged 8 commits into from
Mar 17, 2014

Conversation

ptcox
Copy link
Contributor

@ptcox ptcox commented Mar 13, 2014

Add consumes interface to Validation/CSCRecHits. Compiles and builds but has not been tested because I don't know how to. This branch incorporates the branch finish_consumes_for_valid_muoncscdigis because it needs those changes in Validation/MuonCSCDigis too, and I don't know how to keep the branches independent.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ptcox for CMSSW_7_1_X.

Consumes for valid cscrechits

It involves the following packages:

Validation/CSCRecHits
Validation/MuonCSCDigis

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 17, 2014

+1
thanks @ptcox

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 17, 2014
Validation -- Consumes for valid cscrechits
@nclopezo nclopezo merged commit b97ec87 into cms-sw:CMSSW_7_1_X Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants