Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE tool: Files for 2016 trends, option to use/not use condor CAF queue #28528

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

mteroerd
Copy link
Contributor

@mteroerd mteroerd commented Dec 3, 2019

PR description:

  • The 2016 runs with their respective luminosities were added so they can be accessed by the plotting tool for APE trends. A typo in the trend plotting tool was also fixed.
  • When a measurement is started that uses loaded conditions from sqlite files, checks are now performed to see if the sqlite files exist. Before, this was not caught so that jobs were submitted to condor and then crashed. At the moment there is still no check if the used tag and record are available in the source.
  • An option is added to submit condor jobs for APE measurements to the CAF queue. It is off by default. With this option, one does not have to connect to lxplus-t0.cern.ch anymore.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28528/13001

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

A new Pull Request was created by @mteroerd (Marius Teroerde) for master.

It involves the following packages:

Alignment/APEEstimation

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @adewit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3760/console Started: 2019/12/03 17:00

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5efb4f/3760/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@pohsun
Copy link

pohsun commented Dec 10, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 66ea8bd into cms-sw:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants