Fix D51 and D52 reco geometry configurations after #28500 #28550

fabiocos · 2019-12-04T17:26:56Z

PR description:

The code reorganization implied by #28500 was not taken into account in #28503 that was developed and integrated in parallel. This causes the newly added test workflows 23634.0 and 24034.0 to crash. This PR fixes the reco geometry configuration.

PR validation:

18:23 cmsdev25 2854> less runall-report-step123-.log 
23634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D51_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D51+RecoFullGlobal_2026D51+HARVESTFullGlobal_2026D51 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Dec  4 18:18:04 2019-date Wed Dec  4 18:03:23 2019; exit: 0 0 0 0
24034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D52_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D52+RecoFullGlobal_2026D52+HARVESTFullGlobal_2026D52 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Wed Dec  4 18:18:04 2019-date Wed Dec  4 18:03:23 2019; exit: 0 0 0 0
2 2 2 2 tests passed, 0 0 0 0 failed

cmsbuild · 2019-12-04T17:27:27Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-12-04T17:33:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28550/13021

This PR adds an extra 12KB to repository

cmsbuild · 2019-12-04T17:33:38Z

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/Geometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2019-12-04T17:39:24Z

please test workflow 23634.0,24034.0

cmsbuild · 2019-12-04T17:39:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3801/console Started: 2019/12/04 18:40

cmsbuild · 2019-12-04T20:48:36Z

-1

Tested at: 7ed018b

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix memory leaks in PVFitter #28509 @MilanoBicocca-pix: Fix memory leaks in PVFitter
fix alignment validation plotting macro #28516 @mmusich: fix alignment validation plotting macro
Recommit on top of last IB the recipe to run the photon validation on… #28511 @nancymarinelli: Recommit on top of last IB the recipe to run the photon validation on
Add Phase 2 TFPX geometries (T17 and T18) #28503 @ghugo83: Add Phase 2 TFPX geometries (T17 and T18)
cyclic dependency: Merge Geometry/CommonDetUnit in to CommonTopologies #28500 @smuzaffar: cyclic dependency: Merge Geometry/CommonDetUnit in to CommonTopologies
DQM: Script to locally run the bin-to-bin comparison tool #28501 @schneiml: DQM: Script to locally run the bin-to-bin comparison tool
Migration of HLT menus to 1100pre13 template (111X) #28519 @cms-tsg-storm: Migration of HLT menus to 1100pre13 template (111X)
make HB TDC conversion configurable #28474 @lwang046: make HB TDC conversion configurable
HCALDQM: Run3 era, add compatibility for new uTCA HO (master) #28484 @DryRun: HCALDQM: Run3 era, add compatibility for new uTCA HO (master)
A fix for importing dependencies in DQM bin by bin tool #28494 @andrius-k: A fix for importing dependencies in DQM bin by bin tool
Update truncated tube shape parameters to match new version of DD4hep #28496 @cvuosalo: Update truncated tube shape parameters to match new version of DD4hep
Adding HTXS Stage 1.2 classification #28444 @adewit: Adding HTXS Stage 1.2 classification
Add LHEPtFilter plugin needed for MC generation #28443 @ajgilbert: Add LHEPtFilter plugin needed for MC generation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3801/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3801/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3801/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test test2026Geometry had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix memory leaks in PVFitter #28509 @MilanoBicocca-pix: Fix memory leaks in PVFitter
fix alignment validation plotting macro #28516 @mmusich: fix alignment validation plotting macro
Recommit on top of last IB the recipe to run the photon validation on… #28511 @nancymarinelli: Recommit on top of last IB the recipe to run the photon validation on
Add Phase 2 TFPX geometries (T17 and T18) #28503 @ghugo83: Add Phase 2 TFPX geometries (T17 and T18)
cyclic dependency: Merge Geometry/CommonDetUnit in to CommonTopologies #28500 @smuzaffar: cyclic dependency: Merge Geometry/CommonDetUnit in to CommonTopologies
DQM: Script to locally run the bin-to-bin comparison tool #28501 @schneiml: DQM: Script to locally run the bin-to-bin comparison tool
Migration of HLT menus to 1100pre13 template (111X) #28519 @cms-tsg-storm: Migration of HLT menus to 1100pre13 template (111X)
make HB TDC conversion configurable #28474 @lwang046: make HB TDC conversion configurable
HCALDQM: Run3 era, add compatibility for new uTCA HO (master) #28484 @DryRun: HCALDQM: Run3 era, add compatibility for new uTCA HO (master)
A fix for importing dependencies in DQM bin by bin tool #28494 @andrius-k: A fix for importing dependencies in DQM bin by bin tool
Update truncated tube shape parameters to match new version of DD4hep #28496 @cvuosalo: Update truncated tube shape parameters to match new version of DD4hep
Adding HTXS Stage 1.2 classification #28444 @adewit: Adding HTXS Stage 1.2 classification
Add LHEPtFilter plugin needed for MC generation #28443 @ajgilbert: Add LHEPtFilter plugin needed for MC generation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3801/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3801/git-merge-result

cmsbuild · 2019-12-04T20:48:39Z

Comparison job queued.

cmsbuild · 2019-12-04T22:03:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3801/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-ca197e/23634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D51_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D51+RecoFullGlobal_2026D51+HARVESTFullGlobal_2026D51
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-ca197e/24034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D52_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D52+RecoFullGlobal_2026D52+HARVESTFullGlobal_2026D52

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2793714
DQMHistoTests: Total failures: 25
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2793348
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 37594.337 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 0.875 KiB Hcal/DigiTask
DQMHistoSizes: changed ( 20034.0,... ): 6255.113 KiB EgammaV/ConversionValidator
DQMHistoSizes: changed ( 20034.0,... ): 1569.811 KiB EgammaV/pfPhotonValidator
DQMHistoSizes: changed ( 20034.0,... ): 1568.629 KiB EgammaV/PhotonValidator
Checked 147 log files, 16 edm output root files, 34 DQM output files

smuzaffar · 2019-12-04T22:21:00Z

please test

cmsbuild · 2019-12-04T22:59:52Z

Pull request #28550 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

fabiocos · 2019-12-04T23:00:54Z

please test workflow 23634.0,24034.0

cmsbuild · 2019-12-04T23:01:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3811/console Started: 2019/12/05 00:04

cmsbuild · 2019-12-05T02:05:35Z

+1
Tested at: ba089cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3811/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix memory leaks in PVFitter #28509 @MilanoBicocca-pix: Fix memory leaks in PVFitter
fix alignment validation plotting macro #28516 @mmusich: fix alignment validation plotting macro
Recommit on top of last IB the recipe to run the photon validation on… #28511 @nancymarinelli: Recommit on top of last IB the recipe to run the photon validation on
Add Phase 2 TFPX geometries (T17 and T18) #28503 @ghugo83: Add Phase 2 TFPX geometries (T17 and T18)
cyclic dependency: Merge Geometry/CommonDetUnit in to CommonTopologies #28500 @smuzaffar: cyclic dependency: Merge Geometry/CommonDetUnit in to CommonTopologies
DQM: Script to locally run the bin-to-bin comparison tool #28501 @schneiml: DQM: Script to locally run the bin-to-bin comparison tool
Migration of HLT menus to 1100pre13 template (111X) #28519 @cms-tsg-storm: Migration of HLT menus to 1100pre13 template (111X)
make HB TDC conversion configurable #28474 @lwang046: make HB TDC conversion configurable
HCALDQM: Run3 era, add compatibility for new uTCA HO (master) #28484 @DryRun: HCALDQM: Run3 era, add compatibility for new uTCA HO (master)
A fix for importing dependencies in DQM bin by bin tool #28494 @andrius-k: A fix for importing dependencies in DQM bin by bin tool
Update truncated tube shape parameters to match new version of DD4hep #28496 @cvuosalo: Update truncated tube shape parameters to match new version of DD4hep
Adding HTXS Stage 1.2 classification #28444 @adewit: Adding HTXS Stage 1.2 classification
Add LHEPtFilter plugin needed for MC generation #28443 @ajgilbert: Add LHEPtFilter plugin needed for MC generation

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3811/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3811/git-merge-result

cmsbuild · 2019-12-05T02:05:38Z

Comparison job queued.

cmsbuild · 2019-12-05T03:14:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca197e/3811/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-ca197e/23634.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D51_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D51+RecoFullGlobal_2026D51+HARVESTFullGlobal_2026D51
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-ca197e/24034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D52_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D52+RecoFullGlobal_2026D52+HARVESTFullGlobal_2026D52

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2793714
DQMHistoTests: Total failures: 25
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2793348
DQMHistoTests: Total skipped: 341
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 37594.337 KiB( 33 files compared)
DQMHistoSizes: changed ( 1000.0,... ): 0.875 KiB Hcal/DigiTask
DQMHistoSizes: changed ( 20034.0,... ): 6255.113 KiB EgammaV/ConversionValidator
DQMHistoSizes: changed ( 20034.0,... ): 1569.811 KiB EgammaV/pfPhotonValidator
DQMHistoSizes: changed ( 20034.0,... ): 1568.629 KiB EgammaV/PhotonValidator
Checked 147 log files, 16 edm output root files, 34 DQM output files

fabiocos · 2019-12-05T08:18:00Z

+1

Changes are unrelated to this PR

fabiocos · 2019-12-05T09:47:31Z

@smuzaffar there is something I do not understand in the report fo the bot, the list of added merges includes things that should ne already in the baseline

fabiocos · 2019-12-05T09:47:37Z

merge

smuzaffar · 2019-12-05T10:02:52Z

looks like tests were run against 11.0.X. I am checking why it happened.

kpedro88 · 2019-12-05T15:17:16Z

+upgrade

cvuosalo · 2019-12-05T21:20:21Z

+1

cmsbuild · 2019-12-05T21:20:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Fix D51 and D52 reco geometry configurations for cms-sw#28500

7ed018b

cmsbuild added this to the CMSSW_11_1_X milestone Dec 4, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Dec 4, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 4, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 4, 2019

cmsbuild added tests-rejected and removed tests-started labels Dec 4, 2019

cmsbuild added comparison-available and removed comparison-pending labels Dec 4, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Dec 4, 2019

cmsbuild added the code-checks-approved label Dec 4, 2019

cmsbuild added tests-started and removed tests-pending labels Dec 4, 2019

cmsbuild added tests-approved and removed tests-started labels Dec 5, 2019

cmsbuild added comparison-available and removed comparison-pending labels Dec 5, 2019

cmsbuild added orp-approved and removed orp-pending labels Dec 5, 2019

cmsbuild merged commit 0a7bc45 into cms-sw:master Dec 5, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Dec 5, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Dec 5, 2019

fabiocos deleted the fc-fix28503 branch December 18, 2019 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix D51 and D52 reco geometry configurations after #28500 #28550

Fix D51 and D52 reco geometry configurations after #28500 #28550

fabiocos commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

fabiocos commented Dec 4, 2019

cmsbuild commented Dec 4, 2019 •

edited

Loading

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

smuzaffar commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

fabiocos commented Dec 4, 2019

cmsbuild commented Dec 4, 2019 •

edited

Loading

cmsbuild commented Dec 5, 2019

cmsbuild commented Dec 5, 2019

cmsbuild commented Dec 5, 2019

fabiocos commented Dec 5, 2019

fabiocos commented Dec 5, 2019

fabiocos commented Dec 5, 2019

smuzaffar commented Dec 5, 2019

kpedro88 commented Dec 5, 2019

cvuosalo commented Dec 5, 2019

cmsbuild commented Dec 5, 2019

Fix D51 and D52 reco geometry configurations after #28500 #28550

Fix D51 and D52 reco geometry configurations after #28500 #28550

Conversation

fabiocos commented Dec 4, 2019

PR description:

PR validation:

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

fabiocos commented Dec 4, 2019

cmsbuild commented Dec 4, 2019 • edited Loading

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

smuzaffar commented Dec 4, 2019

cmsbuild commented Dec 4, 2019

fabiocos commented Dec 4, 2019

cmsbuild commented Dec 4, 2019 • edited Loading

cmsbuild commented Dec 5, 2019

cmsbuild commented Dec 5, 2019

cmsbuild commented Dec 5, 2019

fabiocos commented Dec 5, 2019

fabiocos commented Dec 5, 2019

fabiocos commented Dec 5, 2019

smuzaffar commented Dec 5, 2019

kpedro88 commented Dec 5, 2019

cvuosalo commented Dec 5, 2019

cmsbuild commented Dec 5, 2019

cmsbuild commented Dec 4, 2019 •

edited

Loading

cmsbuild commented Dec 4, 2019 •

edited

Loading