Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-sim50 Use EcalSimulationParameters in ECalSD #28563

Merged
merged 2 commits into from Dec 10, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 5, 2019

PR description:

Use EcalSimulationParameters rather DDCompressedView in ECalSD and the corresponding changes in the python scripts

PR validation:

Tested using runTheMatrix.py

if this PR is a backport please specify the original PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28563/13050

  • This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 5, 2019

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28563/13051

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3832/console Started: 2019/12/05 18:37

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
SimG4CMS/Calo
SimG4CMS/HcalTestBeam

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

cvuosalo commented Dec 5, 2019

@bsunanda What portion of the ECal sensitive detector DD4hep migration does this PR represent?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-948673/3832/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799741
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 6, 2019

@cvuosalo I believe for ECAL this is now complete

@cvuosalo
Copy link
Contributor

cvuosalo commented Dec 6, 2019

+1

@civanch
Copy link
Contributor

civanch commented Dec 6, 2019

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 9, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dc8db28 into cms-sw:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants