Add enforceGUIDInFileName option to PoolSource and EmbeddedRootSource (9_3_X)

[makortel]

PR description:

Quoting original PR

This PR adds an option to PoolSource and EmbeddedRootSource to enforce that the file name (without extension) corresponds the GUID of the file. The added configuration parameter is enforceGUIDInFileName = cms.untracked.bool, and is set to false by default to preserve the current behavior. In case of a mismatch a new error code 8034 (FileNameInconsistentWithGUID) is returned.

The motivation for such an option comes from dmwm/WMCore#9432.

PR validation:

Unit tests run.

if this PR is a backport please specify the original PR:

Backport of #28561. There are two small differences wrt. original PR: stemFromPath() operates on std::string instead of std::string_view, and its unit test does not use catch2.

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_3_X.

It involves the following packages:

FWCore/Framework
FWCore/MessageLogger
FWCore/Utilities
IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@felicepantaleo, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3919/console Started: 2019/12/10 23:14

[cmsbuild]

+1
Tested at: 364d7ef
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-859d9a/3919/summary.html
Additional comment: 'Compilation

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-859d9a/3919/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 25
• DQMHistoTests: Total histograms compared: 2624448
• DQMHistoTests: Total failures: 232
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2624039
• DQMHistoTests: Total skipped: 177
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
• Checked 105 log files, 8 edm output root files, 25 DQM output files

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1