Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further code review from the end of #2730 #2866

Merged
merged 1 commit into from
Mar 17, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Mar 14, 2014

This is a technical PR that addresses code review points that arose in #2730.
No expected changed in physics output, timing for rechits should be improved.

@bachtis -- this covers most of the stuff you and Slava were discussing last night too

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_1_X.

Further code review from the end of #2730

It involves the following packages:

DataFormats/ParticleFlowReco
RecoParticleFlow/PFClusterProducer

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 14, 2014

code seems ok, waiting for jenkins

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 17, 2014

+1

for #2866 b98d75b
based on code check and jenkins tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 17, 2014
Reco -- Further code review from the end of #2730
@ktf ktf merged commit a649877 into cms-sw:CMSSW_7_1_X Mar 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants