Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11_0_X] [HLTrigger/JSONMonitoring] updated sanity check in L1TriggerJSONMonitoring #28798

Merged

Conversation

missirol
Copy link
Contributor

Backport of #28797

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2020

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_11_0_X.

It involves the following packages:

HLTrigger/JSONMonitoring

@cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Jan 27, 2020

type bugfix

@fwyzard
Copy link
Contributor

fwyzard commented Jan 27, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4369/console Started: 2020/01/27 16:51

@cmsbuild
Copy link
Contributor

+1
Tested at: f5d5832
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b46b21/4369/summary.html
CMSSW: CMSSW_11_0_X_2020-01-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b46b21/4369/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Jan 28, 2020
@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3caf6b2 into cms-sw:CMSSW_11_0_X Jan 29, 2020
@missirol missirol deleted the devel_L1TriggerJSONMonitoring_110X branch January 29, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants