Remove EntryDescriptionRegistry #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@nclopezo please test. |
|
Hi, I took these changes on top of CMSSW_7_0_X_2013-08-13-0200, I ran the unit tests and Relvals. All tests passed. |
|
@Dr15Jones can you please sign off? |
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
parbol
pushed a commit
to parbol/cmssw
that referenced
this pull request
Mar 5, 2015
lepton MVA updates
makortel
pushed a commit
to makortel/cmssw
that referenced
this pull request
Apr 22, 2015
Update log deletion policy.
cmantill
pushed a commit
to cmantill/cmssw
that referenced
this pull request
Jan 25, 2019
…n_102x [RFC] Call nanoAOD_runMETfixEE2017() only if the modifiers are chosen (102X)
makortel
pushed a commit
to makortel/cmssw
that referenced
this pull request
Mar 15, 2019
slava77
pushed a commit
to slava77/cmssw
that referenced
this pull request
Oct 9, 2021
Update PandorasBox before merging fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EntryDescriptionRegistry is a singleton that is used only for reading the provenance in old files written in or after CMSSW_2_1_0 but before CMSSW_3_0_0. Singletons are bad for the multithreaded framework, so this pull request eliminates this singleton. In this particular case, the data held by this singleton is not needed outside the input source, so it is relatively easy to eliminate the use of a singleton.