Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testSiStripPayloadInspector for Py3 #28842

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 31, 2020

resolves #28837

PR description:

Title says it all. Changes made in order to make testSiStripPayloadInspector work in python3.

PR validation:

PR has been tested in Py3 environment in CMSSW_11_1_PY3_X_2020-01-30-2300
Validation relies on existing unit tests, which now run successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is meant.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28842/13591

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28842/13592

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor

ggovi commented Feb 3, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4476/console Started: 2020/02/03 16:56

@ggovi
Copy link
Contributor

ggovi commented Feb 3, 2020

please test for CMSSW_11_1_PY3_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

+1
Tested at: 9a43cad
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61d9d2/4476/summary.html
CMSSW: CMSSW_11_1_X_2020-02-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61d9d2/4476/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697068
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2696721
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

Kind reminder to @ggovi
This fix should solve one of the few failing tests in the PY3 IB.

@ggovi
Copy link
Contributor

ggovi commented Feb 6, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PY3] Unit test CondCore/SiStripPlugins
4 participants