Migrate EcalSimHitsValidation classes to DQMEDAnalyzer

[makortel]

PR description:

Inspired by the discussion in #28920 this PR migrates four legacy DQM analyzers in Validation/EcalHits that are being run in matrix workflows to DQMEDAnalyzer.

There are two functional changes

• The analyzers do not run without DQMStore service
  • Previously the code had an attempt to be able to run without DQMStore by booking the MonitorElements only if DQMStore is present, and in the analyze() by protecting (almost) all the Fill() calls
• EcalSimHitsValidation's ability to save the DQMStore state into a file in the destructor of the analyzer is removed

PR validation:

Matrix workflow 25.0 (and more, but I did not explicitly test the limited matrix) runs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28966/13795

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Validation/EcalHits

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4680/console Started: 2020/02/14 21:22

[cmsbuild]

+1
Tested at: e2ac3d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37149c/4680/summary.html
CMSSW: CMSSW_11_1_X_2020-02-14-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37149c/4680/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2693986
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693636
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.019 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -0.001 KiB EcalHitsV/EcalSimHitsValidation
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[schneiml]

Thanks @makortel ! Another batch of legacy modules removed.

In the PR comparison, it looks you changed a space character in EcalHitsV/EcalSimHitsValidation/EB E9oE16. That should probably be fixed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28966/13805

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #28966 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4706/console Started: 2020/02/17 16:31

[cmsbuild]

+1
Tested at: ef18fcf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37149c/4706/summary.html
CMSSW: CMSSW_11_1_X_2020-02-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37149c/4706/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2694005
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2693655
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

In
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37149c/4706/runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step4_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
we have a new warning

%MSG-e HLTConfigProvider:   EgHLTOfflineSummaryClient:egHLTOffDQMSummaryClient@beginRun  17-Feb-2020 16:48:29 CET Run: 1
 Process name 'HLT' not found in registry!
%MSG

It is originated from
https://github.com/cms-sw/cmssw/blob/master/DQMOffline/Trigger/plugins/EgHLTOfflineSummaryClient.cc#L35
https://github.com/cms-sw/cmssw/blob/master/HLTrigger/HLTcore/src/HLTConfigProvider.cc#L193
Anyway, I think it is not a big problem since the output does not change.