-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate EcalSimHitsValidation classes to DQMEDAnalyzer #28966
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28966/13795
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Validation/EcalHits @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Thanks @makortel ! Another batch of legacy modules removed. In the PR comparison, it looks you changed a space character in |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28966/13805
|
Pull request #28966 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 In
It is originated from |
PR description:
Inspired by the discussion in #28920 this PR migrates four legacy DQM analyzers in
Validation/EcalHits
that are being run in matrix workflows toDQMEDAnalyzer
.There are two functional changes
DQMStore
serviceDQMStore
by booking the MonitorElements only ifDQMStore
is present, and in theanalyze()
by protecting (almost) all theFill()
callsEcalSimHitsValidation
's ability to save theDQMStore
state into a file in the destructor of the analyzer is removedPR validation:
Matrix workflow 25.0 (and more, but I did not explicitly test the limited matrix) runs.