Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dqm muon alignment #29027

Merged
merged 6 commits into from Feb 25, 2020
Merged

Conversation

jfernan2
Copy link
Contributor

PR description:

DQMOffline/Alignment/ MuonAlignment module not been used any longer
The change affects to all AlCaRecos starting with pathALCARECOMuAl* which were producing DQM plots with this module but are NOT needed at present

PR validation:

Tested several AlCarecos:
runTheMatrix.py -l 10006.0,10806.0,10042.0,1308.0,1307.0,7.23,7.0,4.22,1004.0 -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport foreseen

This PR tries to fix the following issues
#28975
and
#28974

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29027/13884

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29027/13885

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

Configuration/StandardSequences
DQMOffline/Alignment
DQMOffline/Configuration

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @threus, @dgulhan, @rociovilar this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor Author

please test workflow 10006.0,10806.0,10042.0,1308.0,1307.0,7.23,7.0,4.22,1004.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 18aa0fc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93c65e/4838/summary.html
CMSSW: CMSSW_11_1_X_2020-02-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-93c65e/4854/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2678222
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2677900
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -39319.189 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -8705.018 KiB AlCaReco/MuAlCalIsolatedMuGeneralTracks
  • DQMHistoSizes: changed ( 1000.0 ): -8652.789 KiB AlCaReco/MuAlCalIsolatedMu
  • DQMHistoSizes: changed ( 1000.0 ): -7149.230 KiB AlCaReco/MuAlCaZMuMuGeneralTracks
  • DQMHistoSizes: changed ( 1000.0 ): -7105.152 KiB AlCaReco/MuAlCaZMuMu
  • DQMHistoSizes: changed ( 1000.0 ): -1533.070 KiB AlCaReco/MuAlOverlapsGeneralTracks
  • DQMHistoSizes: changed ( 1000.0 ): -1530.428 KiB AlCaReco/MuAlZMuMuGeneralTracks
  • DQMHistoSizes: changed ( 1000.0 ): -1524.920 KiB AlCaReco/MuAlOverlaps
  • DQMHistoSizes: changed ( 1000.0 ): -1522.277 KiB AlCaReco/MuAlZMuMu
  • DQMHistoSizes: changed ( 1000.0 ): -0.016 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): -0.016 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 7.3 ): ...
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

This PR is removing all plots in AlCaReco in wf 1000.0.
Was this expected?

@silviodonato
Copy link
Contributor

@jfernan2

@silviodonato
Copy link
Contributor

I see from #28975 (comment) that this was actually expected

@silviodonato
Copy link
Contributor

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@christopheralanwest,@franzoni,@tlampen,@pohsun,@tocheng you have been requested to review this Pull request/Issue and eventually sign? Thanks

@silviodonato
Copy link
Contributor

@christopheralanwest,@franzoni,@tlampen,@pohsun,@tocheng we are removing the module DQMOffline/Alignment/MuonAlignment from CMSSW. This module is used in wf 1000.0. Please note this module different from Alignment/MuonAlignment/MuonAlignment .
As @jfernan2 wrote in #28975 (comment), this module is not longer used for muon alignment.
This PR solves #28975 and #28974.

@silviodonato
Copy link
Contributor

+operations

@tocheng
Copy link
Contributor

tocheng commented Feb 25, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@jfernan2
Copy link
Contributor Author

@silviodonato sorry if I did not spread the news enough: I got green from AlCa and Muon Alignment group before creating the PR, which is not emoving ALL AlCa plots but those produced (for historical reasons) in the Muon Alignment DQM which are at present empty and not used.
Thanks for checking anyway!

@mmusich
Copy link
Contributor

mmusich commented Feb 25, 2020

once upon a time having an AlCa DQM module to monitor what was actually produced in the ALCARECOs was a conditio sine qua non to actually get the green light for production.
I am wondering what has changed in the policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants