-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete dqm muon alignment #29027
Delete dqm muon alignment #29027
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29027/13884
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29027/13885
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages: Configuration/StandardSequences @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 10006.0,10806.0,10042.0,1308.0,1307.0,7.23,7.0,4.22,1004.0 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This PR is removing all plots in AlCaReco in wf 1000.0. |
I see from #28975 (comment) that this was actually expected |
assign alca |
New categories assigned: alca @christopheralanwest,@franzoni,@tlampen,@pohsun,@tocheng you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@christopheralanwest,@franzoni,@tlampen,@pohsun,@tocheng we are removing the module DQMOffline/Alignment/MuonAlignment from CMSSW. This module is used in wf 1000.0. Please note this module different from Alignment/MuonAlignment/MuonAlignment . |
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@silviodonato sorry if I did not spread the news enough: I got green from AlCa and Muon Alignment group before creating the PR, which is not emoving ALL AlCa plots but those produced (for historical reasons) in the Muon Alignment DQM which are at present empty and not used. |
once upon a time having an AlCa DQM module to monitor what was actually produced in the ALCARECOs was a |
PR description:
DQMOffline/Alignment/ MuonAlignment module not been used any longer
The change affects to all AlCaRecos starting with pathALCARECOMuAl* which were producing DQM plots with this module but are NOT needed at present
PR validation:
Tested several AlCarecos:
runTheMatrix.py -l 10006.0,10806.0,10042.0,1308.0,1307.0,7.23,7.0,4.22,1004.0 -i all --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport foreseen
This PR tries to fix the following issues
#28975
and
#28974