CSC migration to DD4HEP #29111
CSC migration to DD4HEP #29111
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29111/14013
|
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Geometry/CSCGeometryBuilder The following packages do not have a category, yet: cmsRecoGeom-2021.root @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@slomeo is this root file a leftover ? |
|
Probably do I need a "git squash"? |
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
new-package-pending
labels
|
The code-checks are being triggered in jenkins. |
|
@slomeo , better to close this and make a new one without root file. Another variant : git rm yourfile.root |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29111/14015 |
|
Pull request #29111 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29111/14111 |
|
Pull request #29111 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
|
This is presumably not a parameter we expect to change frequently in the long term - its currently a expert developer switch which will go to always true once complete, no?
On Mar 11, 2020, at 9:35 AM, Fabio Cossutti <notifications@github.com<mailto:notifications@github.com>> wrote:
@fabiocos commented on this pull request.
________________________________
In Geometry/CSCGeometryBuilder/plugins/CSCGeometryESModule.cc<#29111 (comment)>:
using namespace edm;
CSCGeometryESModule::CSCGeometryESModule(const edm::ParameterSet& p)
- : alignmentsLabel_(p.getParameter<std::string>("alignmentsLabel")),
+ : useDDD_(p.getParameter<bool>("useDDD")),
+ useDD4hep_{p.getUntrackedParameter<bool>("useDD4hep", false)},
please keep in mind that we have a process modifier https://cmssdt.cern.ch/lxr/source/Configuration/ProcessModifiers/python/dd4hep_cff.py that can be used to centralize settings change. This could help in tracking in a transparent way the set of needed modifications
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29111?email_source=notifications&email_token=ABGPFQ7BH763YPBBUPXP7ITRG5EO7A5CNFSM4LCITPRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCY2MHTI#discussion_r390812287>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ7B2FEOGYCFTL53JTDRG5EO7ANCNFSM4LCITPRA>.
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@davidlange6 in my view as soon as the migration is completed, also in terms of validation, the old DDD code should be progressively de-commissioned, so at the end of the process there will be no more special setting to be tracked, But I am afraid this is neither for tomorrow nor for April. So in the meanwhile the modifier may help in managing transparently one setup vs the other. |
|
the issue of the parameter useDD4hep_ will be fixed in a dedicated PR, please merge #29111 in order to give the opportunity to Adinda De Wit & Marco Musich keep on their job about Traker/Muon Alignment |
|
+1 |
PR description:
CSC migration to DD4HEP:
This PR covers Sim / Numbering / Validation
No editing for Reco files
It doesn't cover Sensitive Detectors.
There are not overlaps for CSC (All Muon Overlaps were fixed in old PRs related to Scenario 2021 and 2026)
Files changed:
Geometry/CSCGeometryBuilder/plugins/CSCGeometryESModule.cc
Geometry/CSCGeometryBuilder/plugins/CSCGeometryESModule.h
Geometry/CSCGeometryBuilder/src/CSCGeometryBuilderFromDDD.cc
Geometry/CSCGeometryBuilder/src/CSCGeometryBuilderFromDDD.h
Geometry/CSCGeometryBuilder/src/CSCGeometryParsFromDD.cc
Geometry/CSCGeometryBuilder/src/CSCGeometryParsFromDD.h
New files adedd:
Geometry/CSCGeometryBuilder/plugins/CSCGeometryValidate.cc
Geometry/MuonNumbering/src/DD4hep_CSCNumberingScheme.cc
Geometry/MuonNumbering/interface/DD4hep_CSCNumberingScheme.h
Validation made by scripts present in Geometry/CSCGeometryBuilder/test/python (i.e see pdf files attached)
CSC5.pdf
CSC6.pdf
CSC7.pdf
CSC8.pdf
CSC9.pdf
CSC10.pdf
CSC11.pdf
CSC12.pdf
CSC13.pdf
CSC1.pdf
CSC2.pdf
CSC3.pdf
CSC4.pdf