-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase of pull request #2785 #2913
Conversation
…cmssw into TrackFindingAM_SV_100314 Conflicts: L1Trigger/TrackFindingAM/test/AMFIT_test.py L1Trigger/TrackFindingAM/test/AMPR_test.py
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC. Rebase of pull request #2785 It involves the following packages: L1Trigger/TrackFindingAM @cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it? |
Tests 10000, 10200, 10400, 11200, 11600, 11800, 12000 and 12800 pass all steps.
I find it hard to believe that's because of this pull request though. I'm not even sure any of the tests check these changes. I'll investigate. |
merge Previous reported errors are unrelated and have been fixed. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps. Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors. |
#2785 wants to change 439 files despite a rebase. After merging with the head of CMSSW_6_2_X_SLHC these are the only files with changes however.
Note that I haven't tested anything yet - I'll do that through this pull request and comment here. #2785 should be closed.
@sviret please check this request. It should be everything you wanted without any changes to other packages.