Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase of pull request #2785 #2913

Merged
merged 5 commits into from
Mar 19, 2014
Merged

Conversation

mark-grimes
Copy link

#2785 wants to change 439 files despite a rebase. After merging with the head of CMSSW_6_2_X_SLHC these are the only files with changes however.

Note that I haven't tested anything yet - I'll do that through this pull request and comment here. #2785 should be closed.

@sviret please check this request. It should be everything you wanted without any changes to other packages.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Rebase of pull request #2785

It involves the following packages:

L1Trigger/TrackFindingAM

@cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link
Author

Tests 10000, 10200, 10400, 11200, 11600, 11800, 12000 and 12800 pass all steps.
Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.
However, tests 11400 and 13000 now seg fault in step 4 with

#5  0x00002b7c734c1a74 in MonitorElement::Fill(double, double) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-18-0200/lib/slc5_amd64_gcc472/libDQMServicesCore.so
#6  0x00002b7c831fbcb4 in HcalDigisClient::HcalDigisEndjob(std::vector<MonitorElement*, std::allocator<MonitorElement*> > const&, std::string) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-18-0200/lib/slc5_amd64_gcc472/pluginValidationHcalDigis.so
#7  0x00002b7c831fc8d8 in HcalDigisClient::runClient() () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-18-0200/lib/slc5_amd64_gcc472/pluginValidationHcalDigis.so
#8  0x00002b7c64b7d330 in edm::EDAnalyzer::doEndRun(edm::RunPrincipal const&, edm::EventSetup const&, edm::CurrentProcessingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-03-18-0200/lib/slc5_amd64_gcc472/libFWCoreFramework.so

I find it hard to believe that's because of this pull request though. I'm not even sure any of the tests check these changes. I'll investigate.

@mark-grimes
Copy link
Author

merge

Previous reported errors are unrelated and have been fixed. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps. Tests 12200, 12400, 12600, 13200 and 13400 fail in step 2 with known errors.

cmsbuild added a commit that referenced this pull request Mar 19, 2014
@cmsbuild cmsbuild merged commit aeb68f0 into cms-sw:CMSSW_6_2_X_SLHC Mar 19, 2014
@mark-grimes mark-grimes deleted the rebase2785 branch April 7, 2014 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants