Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Run3 GEM to use the eMap from the DB #29195

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

watson-ij
Copy link
Contributor

@watson-ij watson-ij commented Mar 12, 2020

PR description:

Preemptive backport of #29194 into 11_0_X, fix for gem in run3 crashing due to not reading the emap from the db.

PR validation:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2020

A new Pull Request was created by @watson-ij (Ian J. Watson) for CMSSW_11_0_X.

It involves the following packages:

EventFilter/GEMRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jshlee, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

@watson-ij why do you want to backport this fix to CMSSW_11_0_X ?

@watson-ij
Copy link
Contributor Author

Hi Silvio, Slava asked me to also make a backport request at the same time as #29194, as this should fix issues with CMSSW crashing while GEM is running in MGWR#1 data.

@cmsbuild
Copy link
Contributor

Pull request #29195 was updated. @perrotta, @silviodonato, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

@silviodonato
Copy link
Contributor

Hi Ian, ok, indeed the MWGR#1 will be in May and then they will continue to use 11_0_X

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2020

@christopheralanwest @tocheng
please clarify if we already have a 11_0 PR with GEM eMap in MC for Run-3 (a backport of #29210 )
Thank you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #29277
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5333/console Started: 2020/03/23 20:54

@cmsbuild
Copy link
Contributor

+1
Tested at: 8fc8b69
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c68e2/5333/summary.html
CMSSW: CMSSW_11_0_X_2020-03-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c68e2/5333/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2020

backport of #29194

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2020

+1

for #29195 8fc8b69

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e837559 into cms-sw:CMSSW_11_0_X Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants