ECAL Digitization: fix logical bug in protection against unwanted gainId values in trivial zero suppression

[fabiocos]

PR description:

This PR addresses the issue #29569 . A logical protection against unwated values of gain identifier is incorrect in the TrivialAmplitudeAlgo class. As far as I can see the fix is simply replacing || with &&, i.e. the gain id must be between 1 and 3 included. This class is very old, and practically unused in production workflows as far as I can see (the ECAL selective readout mechanism is used).

PR validation:

Code compiles, wf 11634.0 runs without apparent effect.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29597/14930

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

SimCalorimetry/EcalZeroSuppressionAlgos

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@rovere, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5922/console Started: 2020/04/30 11:30

[cmsbuild]

+1
Tested at: 4451098
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4beef1/5922/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4beef1/5922/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696435
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696115
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1