New functions and Classes to enable HGCDigitizer to implement timing description for HGCal cells in a Premix Workflow.

[adas1994]

PR description:

New functions and Classes to enable HGCDigitizer to implement timing description for HGCal cells in a Premix Workflow With Modified Class Name- Follow-up From PR-29591

This PR aims to add -

1. Two new functionalities in the HGCDigitizer module "loadSimHitAccumulator_forPreMix" and "saveSimHitAccumulator_forPreMix" to handle timing for HGCal in a premix workflow.

2. It also introduces a bunch of modifications to the existing class PHGCSimAccumulator for Premix workflow.

3. Necessary changes also have been made to the plugin modules SimCalorimetry/HGCalSimProducers/plugins/PreMixingHGCalWorker.cc and SimCalorimetry/HGCalSimProducers/plugins/HGCDigiProducer.h and SimGeneral/MixingModule/python/aliases_cfi.py

4. It also introduces a few new datatypes in SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerTypes.h

PR validation:

Validation was done using the standard validation step in the 20634.99 and 20634.0 workflow and also a custom timing validation package.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29793/15266

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimGeneral/MixingModule/python/aliases_cfi.py modified in PR(s): Ecal phase2 sim reco 11 1 x #29386

[cmsbuild]

A new Pull Request was created by @adas1994 for master.

It involves the following packages:

DataFormats/HGCDigi
SimCalorimetry/HGCalSimProducers
SimGeneral/MixingModule

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @rovere, @lgray, @cseez, @apsallid, @pfs, @deguio, @hatakeyamak, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

@adas1994 this looks good. Two minor things to improve

• since your original PR, a code formatter was run on the xml files. Can you go through and revert any changes in spacing in the xml files?
• the change in aliases_cfi.py is also now superfluous, so could be reverted.

[kpedro88]

test parameters
workflows = 23434.1001,20634.99

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 23434.1001,20634.99
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6206/console Started: 2020/05/11 00:58

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29793/15267

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #29793 was updated. @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 23434.1001,20634.99
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6207/console Started: 2020/05/11 02:28

[cmsbuild]

+1
Tested at: 114a3e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6660f8/6207/summary.html
CMSSW: CMSSW_11_1_X_2020-05-10-0000
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6660f8/6207/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-6660f8/20634.99_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41PU_GenSimHLBeamSpotFull14+PREMIX_2026D41PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2026D41PU+RecoFullGlobalPUPRMX_2026D41PU+HARVESTFullGlobalPU_2026D41PU
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-6660f8/23434.1001_TTbar_14TeV+RecoFullGlobalPU_TestOldDigi_2026D49PU+HARVESTFullGlobalPU_2026D49PU

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 26
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697182
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[adas1994]

Thanks @kpedro88 . Do I get notification again, when the PR is merged and the code is integrated in one of the master IBs of CMSSW?

[kpedro88]

@adas1994 please be careful about tagging the right people in github, my user name is @kpedro88

You will get a notification when the PR is merged. If you want to check when it is in an IB, use this page: https://cmssdt.cern.ch/SDT/html/showIB.html

[silviodonato]

+1
FYI @fwyzard @trtomei this PR passed wf 23434.1001 (old 11_0 digi)