-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: remove thermal screen from ETL D53 #29800
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29800/15287
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
abort |
Jenkins tests are aborted. |
hold |
Pull request has been put on hold by @fabiocos |
The code-checks are being triggered in jenkins. |
The latest fix is needed to avoid an overlap with the mother volume, not present in the version with the polycone by @icosivi . The g4OverlapsCheck shows no issue. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29800/15294
|
Pull request #29800 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
unhold |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR, based on the work by @icosivi as discussed and agreed with @bsunanda and N. Koss, removes from the ETL TDR description as implemented in scenario D53 the front thermal screen, which is already included in the volume outside
EndcapTimingLayer
.I have taken the opportunity to move the main volume from a polycone to a tubs (i.e. a cyclindrical shell), which is simpler for the geometry navigation.
This PR fully embeds #29647, it may be rebased after the integration of that.
PR validation:
@icosivi has verified the positions and checked that no overlap is present after this update. I have checked that the volume paths and DetIds are identical after the update (as they should), just longitudinal positions are shifted along z (as expected). The initial part of the dump differences is: