-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply code checks to the DataFormats packages #29883
Apply code checks to the DataFormats packages #29883
Conversation
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
@cmsbuild, please test |
@cmsbuild, please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29883/15485
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: DataFormats/Candidate @perrotta, @smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @slava77, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: aba29a7 CMSSW: CMSSW_11_1_X_2020-05-18-1100 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTauEmbeddingProducers had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@cmsbuild, please test |
The tests are being triggered in jenkins. |
-1 Tested at: aba29a7 CMSSW: CMSSW_11_1_X_2020-05-18-1100 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTauEmbeddingProducers had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). |
Apply
clang-tidy
automated code changes.Apply
clang-format
automated code formatting.