Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply code checks to the DataFormats packages #29883

Merged
merged 4 commits into from May 20, 2020
Merged

Apply code checks to the DataFormats packages #29883

merged 4 commits into from May 20, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 18, 2020

Apply clang-tidy automated code changes.
Apply clang-format automated code formatting.

@fwyzard
Apply clang-tidy automated code changes
62b1abb 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Apply clang-tidy automated code changes
0b0099b 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Apply clang-tidy automated code changes
79301f3 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Apply clang-tidy automated code changes
aba29a7 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Copy link
Contributor Author

fwyzard commented May 18, 2020

@cmsbuild, please test

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 18, 2020
@fwyzard fwyzard changed the base branch from master to CMSSW_11_1_X May 18, 2020 21:03
@fwyzard fwyzard changed the base branch from CMSSW_11_1_X to master May 18, 2020 21:03
@fwyzard
Copy link
Contributor Author

fwyzard commented May 18, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29883/15485

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6403/console Started: 2020/05/18 23:13

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DataFormats/Candidate
DataFormats/Common
DataFormats/Math
DataFormats/PatCandidates

@perrotta, @smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @slava77, @santocch can you please review it and eventually sign? Thanks.
@gouskos, @makortel, @felicepantaleo, @cbernet, @wddgit, @fabiocos, @rovere, @hatakeyamak, @gpetruc, @peruzzim this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: aba29a7

CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00b155/6403/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00b155/6403/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694416
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@fwyzard
Copy link
Contributor Author

fwyzard commented May 19, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6410/console Started: 2020/05/19 09:33

@cmsbuild
Copy link
Contributor

-1

Tested at: aba29a7

CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00b155/6410/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTauEmbeddingProducers had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00b155/6410/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 44
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694373
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical
  • Unit test failing also in the IB

@silviodonato
Copy link
Contributor

merge
cc: @santocch

@cmsbuild cmsbuild merged commit b015841 into cms-sw:master May 20, 2020
@fwyzard fwyzard deleted the Apply_clang-format_DataFormats branch May 20, 2020 08:29
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available core-approved fully-signed orp-approved reconstruction-approved tests-rejected
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fwyzard @cmsbuild @makortel @perrotta @silviodonato @santocch