Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply code checks to the RecoBTag packages #29893

Merged
merged 2 commits into from
May 18, 2020
Merged

Apply code checks to the RecoBTag packages #29893

merged 2 commits into from
May 18, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 18, 2020

Apply clang-tidy automated code changes.
Apply clang-format automated code formatting.

@fwyzard
Apply clang-tidy automated code changes
898135b 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Apply clang-tidy automated code changes
5efb0db 
Enabled checks:
    boost-use-to-string
    misc-uniqueptr-reset-release
    modernize-deprecated-headers
    modernize-make-shared
    modernize-use-bool-literals
    modernize-use-equals-delete
    modernize-use-nullptr
    modernize-use-override
    performance-unnecessary-copy-initialization
    readability-container-size-empty
    readability-redundant-string-cstr
    readability-static-definition-in-anonymous-namespace
    readability-uniqueptr-delete-release
@fwyzard
Copy link
Contributor Author

fwyzard commented May 18, 2020

@cmsbuild, please test

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 18, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29893/15468

  • This PR adds an extra 20KB to repository

  • Found files with invalid states:

    • Traceback (most recent call last):
      • File "/data/cmsbld/jenkins/workspace/run-pr-code-checks/cms-bot/process-pull-request", line 37, in
        • for c in pr.get_commits():
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/PyGithub/github/PaginatedList.py", line 49, in iter
        • newElements = self._grow()
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/PyGithub/github/PaginatedList.py", line 61, in _grow
        • newElements = self._fetchNextPage()
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/PyGithub/github/PaginatedList.py", line 162, in _fetchNextPage
        • headers=self.__headers
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/PyGithub/github/Requester.py", line 172, in requestJsonAndCheck
        • return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/PyGithub/github/Requester.py", line 213, in requestJson
        • return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/PyGithub/github/Requester.py", line 252, in __requestEncode
        • status, responseHeaders, output = self.__requestRaw(cnx, verb, url, requestHeaders, encoded_input)
      • File "/cvmfs/cms-ib.cern.ch/jenkins-env/python/PyGithub/github/Requester.py", line 279, in __requestRaw
        • response = cnx.getresponse()
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/httplib.py", line 1121, in getresponse
        • response.begin()
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/httplib.py", line 438, in begin
        • version, status, reason = self._read_status()
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/httplib.py", line 394, in _read_status
        • line = self.fp.readline(_MAXLINE + 1)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/socket.py", line 480, in readline
        • data = self._sock.recv(self._rbufsize)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/ssl.py", line 779, in recv
        • return self.read(buflen)
      • File "/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/ssl.py", line 659, in read
        • v = self._sslobj.read(len)
    • ssl.SSLError: ('The read operation timed out',)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2020 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6382/console Started: 2020/05/18 14:12

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

RecoBTag/SecondaryVertex
RecoBTag/XMLCalibration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @smoortga, @JyothsnaKomaragiri, @mverzett, @ferencek, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 5efb0db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-726471/6382/summary.html
CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-726471/6382/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694368
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e9a2e18 into cms-sw:master May 18, 2020
@fwyzard fwyzard deleted the Apply_clang-format_RecoBTag branch May 18, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @perrotta @silviodonato