Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMTF: Drop rpcRecHits input #29899

Merged
merged 1 commit into from
May 19, 2020
Merged

EMTF: Drop rpcRecHits input #29899

merged 1 commit into from
May 19, 2020

Conversation

jiafulow
Copy link
Contributor

@jiafulow jiafulow commented May 18, 2020

PR description:

As requested by @makortel , this PR removes the rpcRecHits input from being used by the EMTF emulator (simEmtfDigis), as it causes the conflict found in #29897 . It doesn't change the behavior of the EMTF emulator, because rpcRecHits is not used at the moment. (It was going to be used to receive Phase-2 iRPC hits, but the use has not yet been implemented.)

PR validation:

N/A

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29899/15481

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jiafulow (Jia Fu Low) for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

@cmsbuild, please test

@makortel
Copy link
Contributor

Thanks for the quick fix!

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6397/console Started: 2020/05/18 19:35

@cmsbuild
Copy link
Contributor

+1
Tested at: 7d72392
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dff4f7/6397/summary.html
CMSSW: CMSSW_11_1_X_2020-05-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dff4f7/6397/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694369
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@silviodonato
Copy link
Contributor

merge
@rekovic please let me know if you have any objections

@cmsbuild cmsbuild merged commit 4c93098 into cms-sw:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants