[HLT]Replaced boost::tuple for std::tuple

[camolezi]

PR description:

Replaced boost::tuple for std::tuple. They have similar functionality and std::tuple should reduce boost dependencies.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29939/15567

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTriggerOffline/Muon/interface/HLTMuonPlotter.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File HLTriggerOffline/Muon/src/HLTMuonPlotter.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File HLTriggerOffline/Muon/src/HLTMuonValidator.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29939/15567/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29939/15567/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29939/15568

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTriggerOffline/Muon/interface/HLTMuonPlotter.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File HLTriggerOffline/Muon/src/HLTMuonPlotter.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File HLTriggerOffline/Muon/src/HLTMuonValidator.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

HLTriggerOffline/Muon

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@missirol, @mtosi, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

@camolezi we don't have you identified as HLT Muon developer(?) in
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Muon
Could you please add yourself to the corresponding e-group (cms-tsg-steam-valdqm-developers-muo?) ?
In addition, can you add to the PR title some tag to clasify it like [HLT] or [HLT Muon]?
Thanks in advance

[camolezi]

@jfernan2
I think that I added myself to the e-group. I also attached a HLT tag in the title. Let me know if something is still missing. thanks.

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6484/console Started: 2020/05/21 19:06

[davidlange6]

just to clarify - @camolezi is not a HLT muon validation developer. He is looking at boost dependencies that are now in the c++ standard library.

[cmsbuild]

+1
Tested at: 0674b03
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54a461/6484/summary.html
CMSSW: CMSSW_11_1_X_2020-05-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54a461/6484/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2694466
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694401
• DQMHistoTests: Total skipped: 49
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 150 log files, 16 edm output root files, 35 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1