Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-ft23 Correct run3 scenario for dd4hep and add the other Phase2 scenarios #29950

Merged
merged 1 commit into from May 25, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 22, 2020

PR description:

Correct run3 scenario for dd4hep and add the other Phase2 scenarios

PR validation:

Use standard runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 22, 2020
@bsunanda bsunanda changed the title Run3-ft23Correct run3 scenario for dd4hep and add the other Phase2 scenarios Run3-ft23 Correct run3 scenario for dd4hep and add the other Phase2 scenarios May 22, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29950/15599

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6513/console Started: 2020/05/22 14:50

@cmsbuild
Copy link
Contributor

+1
Tested at: 5c4e032
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79d11a/6513/summary.html
CMSSW: CMSSW_11_1_X_2020-05-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79d11a/6513/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694368
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

@bsunanda eventually we should duplicate/extend/modify the phase 2 geometry scripts so this can be maintained more automatically

@kpedro88
Copy link
Contributor

+upgrade

@smuzaffar smuzaffar modified the milestones: CMSSW_11_1_X, CMSSW_11_2_X May 22, 2020
@cvuosalo
Copy link
Contributor

The Run 3 change, at least, should be backported into 11_1.

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a592fcf into cms-sw:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants