Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to HCAL Run 3 conditions [11_1_X] #30233

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR is a backport of #30195 and updates HCAL Run 3 conditions.

The GT diffs are the same as in the PR to master:

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_design_v4/111X_mcRun3_2021_design_v5

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_realistic_v4/111X_mcRun3_2021_realistic_v5

2021 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021cosmics_realistic_deco_v4/111X_mcRun3_2021cosmics_realistic_deco_v5

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_realistic_HI_v5/111X_mcRun3_2021_realistic_HI_v6

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2023_realistic_v4/111X_mcRun3_2023_realistic_v5

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2024_realistic_v4/111X_mcRun3_2024_realistic_v5

PR validation:

See the description of #30195 for details. In addition, a technical test was performed:

runTheMatrix.py -l limited,7.23,159.0,12834.0 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #30195. These updated conditions are needed for MC production in 11_1_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2020

A new Pull Request was created by @christopheralanwest for CMSSW_11_1_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

test parameters
workflow = 7.23,159.0,12834.0

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: dbaced8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c3dcb/7050/summary.html
CMSSW: CMSSW_11_1_X_2020-06-14-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c3dcb/7050/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c3dcb/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8c3dcb/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4133 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 19668
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2761074
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@christopheralanwest
Copy link
Contributor Author

backport #30195

@christopheralanwest
Copy link
Contributor Author

+1

  • GT diffs identical to those in the corresponding PR to master
  • Pattern of comparison test differences the same as in the PR to master

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0a68872 into cms-sw:CMSSW_11_1_X Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants