-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old duplicate vfatstatusdigi #30547
Conversation
This is actually defined in EventFilter/GEMRawToDigi and this copy is unused.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30547/16777
|
A new Pull Request was created by @watson-ij (Ian J. Watson) for master. It involves the following packages: DataFormats/GEMDigi @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Remove VFatStatusDigi from DataFormats/GEMDigi (this is an old duplicate of the current EventFilter/GEMRawToDigi and shouldn't have been used anyway for quite some time).
@jshlee
PR validation:
Check it compiled and ran a test 2021 10mu workflow.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: