Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX-based Higgs to bb Interaction Network Tagger [10_6_X] #30584

Merged
merged 2 commits into from
Jul 20, 2020

Conversation

jmduarte
Copy link
Member

@jmduarte jmduarte commented Jul 7, 2020

PR description:

Adds the Higgs to bb Interaction Network tagger into CMSSW.

Needs cms-data/RecoBTag-Combined#30.

PR validation:

Checked to reproduce DeepAK8 and ParticleNet jet tags locally.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #30072 for use in 10_6_X NanoAOD.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2020

A new Pull Request was created by @jmduarte (Javier Duarte) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/FeatureTools
RecoBTag/MXNet
RecoBTag/ONNXRuntime

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @hqucms, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2020

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/RecoBTag-Combined#30

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

+1
Tested at: 2c1866d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06c902/7773/summary.html
CMSSW: CMSSW_10_6_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-06c902/7773/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 41212 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214558
  • DQMHistoTests: Total failures: 417099
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2797122
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 24.974 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.786 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10824.0,... ): 12.992 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): -0.225 KiB SiStrip/MechanicalView
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2020

Reco comparison results: 41212 differences found in the comparisons

something strange happened in the build here or at run time. It looks like the baseline and this PR test simulation step was not reproducible.

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/RecoBTag-Combined#30

@slava77
Copy link
Contributor

slava77 commented Jul 16, 2020

+1

for #30584 fbb6005

  • the backport appears to be appropriate
    • the default behavior is left essentially unchanged to satisfy the no-change policy; as discussed in ONNX-based Higgs to bb Interaction Network Tagger [10_6_X] #30584 (comment) this backport contains a technical fix to handling inf/nan inputs, which is not present in the baseline but can possibly appear rarely; this makes it an operational bugfix (OK for rare cases which otherwise produce unphysical/nan values)
    • the new tagger is enabled with the _devel modifier to be available for use in the UL re-miniAOD workflows
  • jenkins tests pass and comparisons with the baseline show no differences

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

test parameters

@silviodonato
Copy link
Contributor

please test
If I understand correctly, cms-data/RecoBTag-Combined#30 was already merged in 10_6_X through cms-sw/cmsdist#6048

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: fbb6005
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e5c8b/8121/summary.html
CMSSW: CMSSW_10_6_X_2020-07-19-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e5c8b/8121/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214618
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214282
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a5c575a into cms-sw:CMSSW_10_6_X Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants