Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 11_2_X L1T TrackTrigger Hybrid Extended ONE Producer. #30615

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jul 9, 2020

PR description:

Turn the L1FPGATrackProducer from edm::stream to edm::one Producer to fix multiple memory consumption at beginRun when running on multiple streams.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@rekovic
Copy link
Contributor Author

rekovic commented Jul 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30615/16878

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Jul 9, 2020

urgent

@cmsbuild cmsbuild added the urgent label Jul 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+1
Tested at: 42f033e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f6f6b/7820/summary.html
CMSSW: CMSSW_11_2_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 92997c6 into cms-sw:master Jul 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f6f6b/7820/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787313
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@srimanob
Copy link
Contributor

@rekovic
How do we know that module should be initialized once/run or once/stream? What is prod/cons in this case?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants