Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New batch scripts #3070

Merged
merged 1 commit into from Apr 1, 2014
Merged

Conversation

sviret
Copy link
Contributor

@sviret sviret commented Mar 28, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sviret (Seb Viret) for CMSSW_6_2_X_SLHC.

New batch scripts

It involves the following packages:

L1Trigger/TrackFindingAM

@cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor

boudoul commented Mar 28, 2014

@sviret
Hi Seb, I see B5ed customs at the end of your one of scripts whereas the MC prod will be done with the TTI scenario where the be5Dpixel10D (Be5D + extendePixels) is used - are you sure that you scripts can work then ?

@andersonjacob
Copy link
Contributor

@sviret We need a reply from you addressing @boudoul to know if we should merge this or hold off a little longer.

@sviret
Copy link
Contributor Author

sviret commented Mar 29, 2014

This script will not be involved in the mc prod, it will be used only by expert users

@andersonjacob
Copy link
Contributor

But Gaelle seems to pointing out a problem with the scripts. Even if it isn't going to be used in production or generation, I don't see a need to merge problematic scripts.

@boudoul
Copy link
Contributor

boudoul commented Mar 30, 2014

If Seb is happy, it's fine, I was just trying to help by reminding him that we are running with the extendedpixel, where the right customisation is not included here, but he is the expert of his script, so if it's merging and he's happy , it's fine , no pb for me.

@mark-grimes
Copy link

merge

If Gaelle is happy. Ran the tests even though I'm pretty sure they don't actually check any of these changes. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000, 12800 and 13000 pass all steps.
13600 fails in step 3, investigating but not considered relevant to this.
12200, 12400, 12600, 13200, 13400 and 14200 fail in step 2 with known errors.
13800, 14000 and 14400 fail in step 1.

cmsbuild added a commit that referenced this pull request Apr 1, 2014
@cmsbuild cmsbuild merged commit 8fea874 into cms-sw:CMSSW_6_2_X_SLHC Apr 1, 2014
@sviret sviret deleted the TrackFindingAM_SV_280314 branch April 11, 2014 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants