Fix for Conddb function to identify current run

[ggovi]

PR description:

This fix replaces a function "getCurrentRun" in the CondDB API ( Session object ) with a more general getLastRun function.
The single client of this function has been adapted to the new semantics.

PR validation:

A unit test has been added. The rest of the CondDB unit and integration test are successfully running

This PR is a backport of #30739
The back-port is required to operate on the HLT workflow

[cmsbuild]

A new Pull Request was created by @ggovi for CMSSW_11_1_X.

It involves the following packages:

CondCore/CondDB
CondCore/DBOutputService
CondCore/Utilities

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[ggovi]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-07-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8037/console Started: 2020/07/17 09:31

[cmsbuild]

-1

Tested at: ebf87d8

CMSSW: CMSSW_11_1_X_2020-07-16-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-916add/8037/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/DBOutputService/src/OnlineDBOutputService.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/DBOutputService/src/PoolDBOutputService.cc 
>> Building shared library tmp/slc7_amd64_gcc820/src/CondCore/DBOutputService/src/CondCoreDBOutputService/libCondCoreDBOutputService.so
/cvmfs/cms-ib.cern.ch/nweek-02637/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/CondCore/DBOutputService/src/CondCoreDBOutputService/OnlineDBOutputService.cc.o: in function `cond::service::OnlineDBOutputService::OnlineDBOutputService(edm::ParameterSet const&, edm::ActivityRegistry&)':
OnlineDBOutputService.cc:(.text+0x1d7a): undefined reference to `cond::persistency::Session::getLastRun()'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc820/src/CondCore/DBOutputService/src/CondCoreDBOutputService/libCondCoreDBOutputService.so] Error 1
Leaving library rule at CondCore/DBOutputService
------- copying files from src/CondCore/DBOutputService/scripts -------
>> copied cmscond_logdb_dump
Entering library rule at src/CondCore/DBOutputService/test


• Clang:

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/CondDB/src/Time.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/CondDB/src/Types.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/CondDB/src/base64.cc 
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/CondDB/src/blowfish.cc 
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/CondDB/src/RunInfoSchema.cc:2:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/CondDB/src/RunInfoSchema.h:46:40: error: non-virtual member function marked 'override' hides virtual member function
        cond::Time_t getLastInserted() override;
                                       ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-07-16-2300/src/CondCore/CondDB/src/IDbSchema.h:222:28: note: hidden overloaded virtual function 'cond::persistency::IRunInfoTable::getLastInserted' declared here: different number of parameters (2 vs 0)
      virtual cond::Time_t getLastInserted(boost::posix_time::ptime& start, boost::posix_time::ptime& end) = 0;
                           ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[ggovi]

please test

[ggovi]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-07-22-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8227/console Started: 2020/07/22 21:46

[cmsbuild]

Pull request #30764 was updated. @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please check and sign again.

[cmsbuild]

+1
Tested at: f4126d0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-916add/8227/summary.html
CMSSW: CMSSW_11_1_X_2020-07-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-916add/8227/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780741
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[ggovi]

+1

[pohsun]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1