Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new return value from FPE #3090

Merged
merged 1 commit into from Mar 29, 2014
Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 28, 2014

This is a fix for the unit test for floating point exceptions in the ROOT 6 IB. The return code from cmsRun when a floating point exception is thrown has changed between ROOT 5 and ROOT 6. This is not fully understood, but is likely due tot eh ROOT signal handler, which cmsRun uses. Since the previous return code in the test was empirically determined, we simply empirically determine the new return code and change it in the test script.

Please merge this promptly unless there are issues.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Use new return value from FPE

It involves the following packages:

FWCore/Services

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Mar 29, 2014
Use new return value from FPE
@davidlt davidlt merged commit 53db600 into cms-sw:CMSSW_7_1_ROOT6_X Mar 29, 2014
@wmtan wmtan deleted the FixFpeUnitTest branch April 15, 2014 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants