[11_1_X] improving performance of PuppiProducer

[missirol]

PR description:

Backport of #31164 with the exception of one commit (e0f02d3) which would introduce small numerical changes in the outputs (see discussion in the original PR); the omission of said commit does not change the improvement in terms of computational performance.

No changes in the outputs are expected.

PR validation:

Checked that the PUPPI weights of all PF candidates are unchanged for 10 events of a Phase-2 workflow, for both puppi (used for jets) and puppiNoLep (used for MET).

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #31164; useful for Phase-2 HLT TDR studies in 11_1_X.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_11_1_X.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @riga, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from improving performance of PuppiProducer #31164

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-08-25-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8914/console Started: 2020/08/25 17:46

[slava77]

backport of #31164

[cmsbuild]

+1
Tested at: 444f651
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-176649/8914/summary.html
CMSSW: CMSSW_11_1_X_2020-08-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-176649/8914/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-176649/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780741
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

+1

for #31241 444f651

• code changes are in line with the PR description. The backport of improving performance of PuppiProducer #31164 is as expected in the context of no-change policy, limited to just the technical changes which do not change the numerical results 3bc16a8...a49a337
• jenkins tests pass and comparisons with the baseline show no differences

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1