Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable wait time for external process communication (11_1_X backport) #31478

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

colizz
Copy link
Contributor

@colizz colizz commented Sep 16, 2020

PR description:

This PR is a backport of #31441 and #31458

The SharedMemory package now allows configurable timeouts for waiting on the external process. The ExternalGeneratorFilter module now has a parameter to control the value. The default is the original 60s.

PR validation:

Code compiles. All unit tests that make use of the SharedMemory package were run and succeeded.
It also solves issue #31426.

The SharedMemory package now allows configurable timeouts for waiting
on the external process. The ExternalGeneratorFilter module now has
a parameter to control the value. The default is the original 60s.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @colizz (Congqiao Li) for CMSSW_11_1_X.

It involves the following packages:

FWCore/Integration
FWCore/SharedMemory
GeneratorInterface/Core

@SiewYan, @smuzaffar, @Dr15Jones, @mkirsano, @makortel, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@makortel, @alberto-sanchez, @mkirsano, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@agrohsje
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 8311bf8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0ae7/9369/summary.html
CMSSW: CMSSW_11_1_X_2020-09-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d0ae7/9369/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8d0ae7/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780741
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@agrohsje
Copy link

+1

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 16, 2020

+1

@cmsbuild cmsbuild merged commit fe67bdf into cms-sw:CMSSW_11_1_X Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants