-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurable wait time for external process communication (11_1_X backport) #31478
Added configurable wait time for external process communication (11_1_X backport) #31478
Conversation
The SharedMemory package now allows configurable timeouts for waiting on the external process. The ExternalGeneratorFilter module now has a parameter to control the value. The default is the original 60s.
A new Pull Request was created by @colizz (Congqiao Li) for CMSSW_11_1_X. It involves the following packages: FWCore/Integration @SiewYan, @smuzaffar, @Dr15Jones, @mkirsano, @makortel, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a backport of #31441 and #31458
The SharedMemory package now allows configurable timeouts for waiting on the external process. The ExternalGeneratorFilter module now has a parameter to control the value. The default is the original 60s.
PR validation:
Code compiles. All unit tests that make use of the SharedMemory package were run and succeeded.
It also solves issue #31426.