Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SHCal tests #3159

Merged
merged 2 commits into from
Apr 2, 2014
Merged

Fix SHCal tests #3159

merged 2 commits into from
Apr 2, 2014

Conversation

mark-grimes
Copy link

This should fix the 138xx and 148xx tests that are currently failing in step 1. They'll fail in step 2 though.
Moved two files to what they're called in the python files. Decided to move them rather than change the python config because the names will then match the tapered version.

@@ -103,7 +103,7 @@
'Geometry/TrackerCommonData/data/PhaseII/BarrelEndcap5D/trackerStructureTopology.xml',
'Geometry/TrackerSimData/data/PhaseII/BarrelEndcap5D/trackersens.xml',
'Geometry/TrackerRecoData/data/PhaseII/BarrelEndcap5D/trackerRecoMaterial.xml',
'Geometry/HGCalCommonData/data/NoTaper/shashlikConstEta3.xml',
'Geometry/HGCalCommonData/data/NoTaper/shashlikConstEta4.xml',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ianna Could you check this line in particular? I assume it's fixing a typo, but it needs confirmation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-grimes - thanks, yes, it is correct.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Fix SHCal tests

It involves the following packages:

Geometry/CMSCommonData
Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Apr 2, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@mark-grimes
Copy link
Author

merge

Tests either pass or fail with known errors.

cmsbuild added a commit that referenced this pull request Apr 2, 2014
@cmsbuild cmsbuild merged commit abec246 into cms-sw:CMSSW_6_2_X_SLHC Apr 2, 2014
@mark-grimes mark-grimes deleted the fixSHCalTest branch April 7, 2014 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants