-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SHCal tests #3159
Fix SHCal tests #3159
Conversation
@@ -103,7 +103,7 @@ | |||
'Geometry/TrackerCommonData/data/PhaseII/BarrelEndcap5D/trackerStructureTopology.xml', | |||
'Geometry/TrackerSimData/data/PhaseII/BarrelEndcap5D/trackersens.xml', | |||
'Geometry/TrackerRecoData/data/PhaseII/BarrelEndcap5D/trackerRecoMaterial.xml', | |||
'Geometry/HGCalCommonData/data/NoTaper/shashlikConstEta3.xml', | |||
'Geometry/HGCalCommonData/data/NoTaper/shashlikConstEta4.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianna Could you check this line in particular? I assume it's fixing a typo, but it needs confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-grimes - thanks, yes, it is correct.
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC. Fix SHCal tests It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it? |
merge Tests either pass or fail with known errors. |
This should fix the 138xx and 148xx tests that are currently failing in step 1. They'll fail in step 2 though.
Moved two files to what they're called in the python files. Decided to move them rather than change the python config because the names will then match the tapered version.