Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix range of Pixel Phase1 digi Validation histos #31619

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

sroychow
Copy link
Contributor

PR description:

This PR fixes the histogram ranges in the DQM/SiPixelPhase1DigisV package - digi row, adc, col histogram axis ranges).

PR validation:

This was validated using wf 11634.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

NO

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31619/18686

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

Validation/SiPixelPhase1DigisV

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@sroychow sroychow changed the title fix range of histos Fix range of Pixel Phase1 digi Validation histos Sep 30, 2020
@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2020

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2020

thanks @sroychow !

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 0244a34
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32ad58/9657/summary.html
CMSSW: CMSSW_11_2_X_2020-09-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32ad58/9657/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2542225
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 240
  • DQMHistoTests: Total successes: 2541956
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 17.504 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 2.188 KiB PixelPhase1V/Digis
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 30, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants