Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE Back Dee Material substitute #3162

Merged
merged 1 commit into from
Apr 3, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Apr 2, 2014

  • Introduce more dense materials to reduce volume
  • Introduce new volumes covering for lost material
  • Re-parent some volumes

Note, everything is there, but EECoolQ substitute is still missing

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

EE Back Dee Material substitute

It involves the following packages:

Geometry/CMSCommonData
Geometry/EcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Apr 2, 2014

@bsunanda and @civanch - could you, please, check if this makes sense? I've increased density of some materials and decreased their volumes. I'm still not sure how to estimate cooling. It's 15.2 cm wide and I have only 4.6 cm free space. It is rather detailed, water plates are 0.05 cm thing. Any suggestions are appreciated. Thanks. Yana

screen shot 2014-04-02 at 16 37 50
screen shot 2014-04-02 at 16 34 14

@ianna
Copy link
Contributor Author

ianna commented Apr 2, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@andersonjacob
Copy link
Contributor

merge

Tests pass which are known to pass, known to fail fail at the same point.

cmsbuild added a commit that referenced this pull request Apr 3, 2014
@cmsbuild cmsbuild merged commit 6b19abe into cms-sw:CMSSW_6_2_X_SLHC Apr 3, 2014
@ianna ianna deleted the shortEE-back-support branch October 26, 2015 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants