-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SonicTriton client to Triton version 2.3 #31715
Conversation
The code-checks are being triggered in jenkins. |
-code-checks ERROR: Build errors found during clang-tidy run.
|
The tests are being triggered in jenkins.
|
@smuzaffar @mrodozov what is the right approach to make the code checks work with new headers from an external update? |
-1 Tested at: feb3396
I found compilation error when building: -- Configuring incomplete, errors occurred! See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/triton-inference-server/2.3.0-db7bb5/build/CMakeFiles/CMakeOutput.log". See also "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc820/external/triton-inference-server/2.3.0-db7bb5/build/CMakeFiles/CMakeError.log". error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.03s2e6 (%build) RPM build errors: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.03s2e6 (%build) You can see the results of the tests here: |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
-code-checks ERROR: Build errors found during clang-tidy run.
|
@makortel thanks for the suggestion, my latest commit also includes code-checks and code-format |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@silviodonato @qliphy this will need to be force-merged (known problem: bot can't run code checks if CMSSW code uses new headers from an external PR) please make sure to merge this together with cms-sw/cmsdist#6297 thanks |
merge |
PR description:
Triton version 2 redesigns the client API. Most of the redesign is just reorganization and renaming. Important Triton changes:
SonicTriton interface changes:
modelVersion = cms.string()
(wascms.int32()
)setShape()
accessors to change one dimension or all dimensions (rather than non-const refshape()
accessor)dims()
accessor removedTritonClient
)The cvmfs server image for tests is updated accordingly (see lgray/triton-torchgeo-gat-example#1).
The corresponding external update is cms-sw/cmsdist#6293.
PR validation:
Ran examples in
HeterogeneousCore/SonicTriton/test
.