Fix initialisation of maxChi2 data member in PVClusterComparer #31725

ats2008 · 2020-10-09T12:09:01Z

modified:   PVClusterComparer.cc

PR description:

Minor bug fix. The code to initialize the maxChi2 values does not do the job, due to an unfortunate typo in the loop break condition.

modified: PVClusterComparer.cc

cmsbuild · 2020-10-09T12:09:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-09T12:15:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31725/18919

This PR adds an extra 12KB to repository

cmsbuild · 2020-10-09T12:16:13Z

A new Pull Request was created by @ats2008 (Aravind Sugunan) for master.

It involves the following packages:

RecoPixelVertexing/PixelVertexFinding

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-10-09T13:10:26Z

@cmsbuild please test

cmsbuild · 2020-10-09T13:10:51Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9829/console Started: 2020/10/09 15:12

slava77 · 2020-10-09T13:11:00Z

@ats2008
please update the PR title to mention what's fixed and where (at least where)

VinInn · 2020-10-09T13:17:06Z

RecoPixelVertexing/PixelVertexFinding/src/PVClusterComparer.cc

@@ -78,7 +78,7 @@ double PVClusterComparer::pTSquaredSum(const reco::Vertex &v) {
 void PVClusterComparer::setChisquareQuantile() {
  std::vector<double> maxChi2(20, 0.);


please do not use variables that differ only for a "_"!

are you sure 20 is safe?

and, btw, why 20?

I am not clear on why it was initialized with 20 elements.

there another function ( PVClusterComparer::updateChisquareQuantile ) that updates the maxChi2_ vector if elements with ndof more than 20 are required.

and its called when those elements need to be accessed, as seen here, so it should be safe.

VinInn · 2020-10-09T13:19:41Z

RecoPixelVertexing/PixelVertexFinding/src/PVClusterComparer.cc

@@ -78,7 +78,7 @@ double PVClusterComparer::pTSquaredSum(const reco::Vertex &v) {
 void PVClusterComparer::setChisquareQuantile() {
  std::vector<double> maxChi2(20, 0.);
  if (track_prob_min_ >= 0. && track_prob_min_ <= 1.)
-    for (size_t ndof = 0; ndof < maxChi2_.size(); ++ndof)
+    for (size_t ndof = 0; ndof < maxChi2.size(); ++ndof)
      // http://root.cern.ch/root/html/TMath.html#TMath:ChisquareQuantile
      maxChi2[ndof] = TMath::ChisquareQuantile(1 - track_prob_min_, ndof);


why not filling maxChi2_ directly?

yes .. it could have been done . I thought i will just make the minor code correction .. but now that its mentioned , I shall update the PR with the code that fills maxChi2_ directly

cmsbuild · 2020-10-09T14:21:53Z

+1
Tested at: 41abcc7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72e7eb/9829/summary.html
CMSSW: CMSSW_11_2_X_2020-10-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-09T14:21:56Z

Comparison job queued.

cmsbuild · 2020-10-12T03:34:08Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-12T03:41:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31725/18969

This PR adds an extra 12KB to repository

cmsbuild · 2020-10-12T03:42:12Z

Pull request #31725 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2020-10-12T05:46:54Z

please test

cmsbuild · 2020-10-12T05:47:10Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-11-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9873/console Started: 2020/10/12 07:49

cmsbuild · 2020-10-12T06:53:29Z

+1
Tested at: f46dea9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72e7eb/9873/summary.html
CMSSW: CMSSW_11_2_X_2020-10-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-12T06:53:32Z

Comparison job queued.

cmsbuild · 2020-10-12T08:24:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-72e7eb/9873/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542194
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-10-12T08:36:54Z

+1

No relevant changes since previous signature in Fix initialisation of maxChi2 data member in PVClusterComparer #31725 (comment)

cmsbuild · 2020-10-12T08:37:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-10-12T11:42:40Z

+1

Fix

41abcc7

modified: PVClusterComparer.cc

cmsbuild added this to the CMSSW_11_2_X milestone Oct 9, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 9, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2020

VinInn reviewed Oct 9, 2020

View reviewed changes

ats2008 changed the title ~~Fix~~ Fix initialisation of maxChi2 data member in PVClusterComparer Oct 9, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 9, 2020

ats2008 added 2 commits October 9, 2020 16:41

adding direct assignment to data member

362a900

code format

8be23f1

cmsbuild added code-checks-pending and removed code-checks-approved tests-approved labels Oct 9, 2020

cmsbuild added comparison-pending pending-signatures reconstruction-pending tests-pending labels Oct 12, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 12, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 12, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 12, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Oct 12, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 12, 2020

cmsbuild merged commit 260347d into cms-sw:master Oct 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix initialisation of maxChi2 data member in PVClusterComparer #31725

Fix initialisation of maxChi2 data member in PVClusterComparer #31725

ats2008 commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

slava77 commented Oct 9, 2020

cmsbuild commented Oct 9, 2020 •

edited

slava77 commented Oct 9, 2020

VinInn Oct 9, 2020 •

edited

VinInn Oct 9, 2020

VinInn Oct 9, 2020

ats2008 Oct 9, 2020

ats2008 Oct 9, 2020

VinInn Oct 9, 2020

ats2008 Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

perrotta commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 •

edited

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

perrotta commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

silviodonato commented Oct 12, 2020

		@@ -78,7 +78,7 @@ double PVClusterComparer::pTSquaredSum(const reco::Vertex &v) {
		void PVClusterComparer::setChisquareQuantile() {
		std::vector<double> maxChi2(20, 0.);

Fix initialisation of maxChi2 data member in PVClusterComparer #31725

Fix initialisation of maxChi2 data member in PVClusterComparer #31725

Conversation

ats2008 commented Oct 9, 2020

PR description:

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

slava77 commented Oct 9, 2020

cmsbuild commented Oct 9, 2020 • edited

slava77 commented Oct 9, 2020

VinInn Oct 9, 2020 • edited

Choose a reason for hiding this comment

VinInn Oct 9, 2020

Choose a reason for hiding this comment

VinInn Oct 9, 2020

Choose a reason for hiding this comment

ats2008 Oct 9, 2020

Choose a reason for hiding this comment

ats2008 Oct 9, 2020

Choose a reason for hiding this comment

VinInn Oct 9, 2020

Choose a reason for hiding this comment

ats2008 Oct 9, 2020

Choose a reason for hiding this comment

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 9, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

perrotta commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 • edited

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

perrotta commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

silviodonato commented Oct 12, 2020

cmsbuild commented Oct 9, 2020 •

edited

VinInn Oct 9, 2020 •

edited

cmsbuild commented Oct 12, 2020 •

edited